Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace println with proper logging #45

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: Replace println with proper logging #45

merged 1 commit into from
Sep 24, 2024

Conversation

philipp-caspers
Copy link
Member

for better filtering etc.

@philipp-caspers philipp-caspers marked this pull request as ready for review September 24, 2024 09:00
AiyionPrime
AiyionPrime approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@AiyionPrime AiyionPrime left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be tested? Or does it suffice to be tested manually once?

@philipp-caspers
Copy link
Member Author

I think it's okay given that the integration tests cover the basic functionality.

@philipp-caspers philipp-caspers merged commit 9141ffe into main Sep 24, 2024
5 checks passed
@philipp-caspers philipp-caspers deleted the refactor/logging branch September 24, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AiyionPrime AiyionPrime AiyionPrime approved these changes

@DS424 DS424 Awaiting requested review from DS424 DS424 is a code owner

@tobiasbrinker tobiasbrinker Awaiting requested review from tobiasbrinker tobiasbrinker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipp-caspers @AiyionPrime